Issue 6947049: code review 6947049: test: s/float/float32/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6947049: code review 6947049: test: s/float/float32/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by iant

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

test: s/float/float32/ I just committed a patch to gccgo that notices that float was never defined, causing an additional unmatched error message. Rename the type to avoid that message.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 98187cf442ac https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b7482cb67996 https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	test/fixedbugs/bug085.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	test/fixedbugs/bug228.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2012-12-13 22:54:54 UTC) #1

minux1

there is another "float" in /test/fixedbugs/bug085.go: // universe scope (contains predeclared identifiers int, float, int32, ...

12 years, 3 months ago (2012-12-13 23:00:04 UTC) #2

iant

On 2012/12/13 23:00:04, minux wrote: > there is another "float" in /test/fixedbugs/bug085.go: > // universe ...

12 years, 3 months ago (2012-12-13 23:09:24 UTC) #3

iant

12 years, 3 months ago (2012-12-13 23:11:40 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=b1822aac85b7 ***

test: s/float/float32/

I just committed a patch to gccgo that notices that float was
never defined, causing an additional unmatched error message.
Rename the type to avoid that message.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/6947049

Expand All Messages | Collapse All Messages