Issue 6944048: code review 6944048: go.crypto/ssh/test: move some variables into common os ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6944048: code review 6944048: go.crypto/ssh/test: move some variables into common os ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by brainman

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

go.crypto/ssh/test: move some variables into common os source file to fix windows build

Patch Set 1 #

Patch Set 2 : diff -r a5fe000a4ea3 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r a5fe000a4ea3 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r a5fe000a4ea3 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r a5fe000a4ea3 https://code.google.com/p/go.crypto #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -79 lines)			Patch
	M	ssh/test/keys_test.go	View	1	1 chunk	+76 lines, -0 lines	0 comments	Download
	M	ssh/test/test_unix_test.go	View	1	2 chunks	+1 line, -79 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto

12 years, 3 months ago (2012-12-14 07:31:10 UTC) #1

brainman

On 2012/12/14 07:32:56, dfc wrote: > LGTM. I do not have access to submit my ...

12 years, 3 months ago (2012-12-14 07:39:24 UTC) #3

brainman

12 years, 3 months ago (2012-12-14 07:45:42 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=59281101794d&repo=crypto ***

go.crypto/ssh/test: move some variables into common os source file to fix
windows build

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/6944048

Expand All Messages | Collapse All Messages