Issue 6943044: code review 6943044: go.talks/present: Lines.line should be always increment...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6943044: code review 6943044: go.talks/present: Lines.line should be always increment... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by egon

Modified:
10 years, 11 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

go.talks/present: Lines.line should be always incremented with Lines.next() Fixes issue 4516

Patch Set 1 #

Patch Set 2 : diff -r 598a884f5100 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 598a884f5100 https://code.google.com/p/go.talks #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	pkg/present/parse.go	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

egon

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 4 months ago (2012-12-13 13:51:52 UTC) #1

adg

11 years, 4 months ago (2012-12-13 22:04:13 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=a067e3468ab3&repo=talks ***

go.talks/present: Lines.line should be always incremented with Lines.next()

Fixes issue 4516

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6943044

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages