Issue 6938052: code review 6938052: cmd/cgo: access errno from void C function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6938052: code review 6938052: cmd/cgo: access errno from void C function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by minux1

Modified:
11 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/cgo: access errno from void C function Fixes issue 3729.

Patch Set 1 #

Patch Set 2 : diff -r 8ea9d438b64e https://code.google.com/p/go/ #

Patch Set 3 : diff -r b7482cb67996 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b7482cb67996 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 640397f24268 https://code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -7 lines)			Patch
M	misc/cgo/test/cgo_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	misc/cgo/test/issue3729.go	View	1 2 3	1 chunk	+47 lines, -0 lines	0 comments	Download
A	misc/cgo/test/issue3729w.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	misc/cgo/test/issue4417.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View	1 2	5 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2012-12-13 22:12:01 UTC) #1

minux1

PTAL Added test for passing arguments to void C function.

11 years, 4 months ago (2012-12-13 22:41:37 UTC) #2

minux1

11 years, 4 months ago (2012-12-17 16:26:20 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=917109e5566b ***

cmd/cgo: access errno from void C function
Fixes issue 3729.

R=rsc
CC=golang-dev
https://codereview.appspot.com/6938052

Expand All Messages | Collapse All Messages