code review 6933049: go.talks/pkg/present: fix image size handling.

go.talks/pkg/present: fix image size handling.

Fixes issue 4527

[francesc, 2012-12-12 03:16:22]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[adg, 2012-12-12 03:17:53]

On 12 December 2012 14:16, <campoy@golang.org> wrote:

> Description:
> go.talks/pkg/present: Fixing image size handling.
>

CL descriptions should be in present tense. In this case:

  go.talks/pkg/present: fix image size handling.

Also don't capitalize the start of the description.

[adg, 2012-12-12 03:18:21]

https://codereview.appspot.com/6933049/diff/4002/present/templates/action.tmpl
File present/templates/action.tmpl (right):

https://codereview.appspot.com/6933049/diff/4002/present/templates/action.tmp...
present/templates/action.tmpl:34: {{define "image"}}<div class="image"><img
src="{{.URL}}" height="{{.Height}}" width="{{.Width}}"></div>{{end}}
this means if width and height aren't set they'll be set to zero

instead:

{{with .Width}} width="{{.}}"{{end}}{{with .Height}} height="{{.}}"{{end}}

[adg, 2012-12-12 03:22:57]

I have been informed that that isn't the present tense, but rather the
imperative tense. In either case, use the tense I used!

[francesc, 2012-12-12 15:57:15]

https://codereview.appspot.com/6933049/diff/4002/present/templates/action.tmpl
File present/templates/action.tmpl (right):

https://codereview.appspot.com/6933049/diff/4002/present/templates/action.tmp...
present/templates/action.tmpl:34: {{define "image"}}<div class="image"><img
src="{{.URL}}" height="{{.Height}}" width="{{.Width}}"></div>{{end}}
On 2012/12/12 03:18:21, adg wrote:
> this means if width and height aren't set they'll be set to zero
> 
> instead:
> 
> {{with .Width}} width="{{.}}"{{end}}{{with .Height}} height="{{.}}"{{end}}

Done.

[adg, 2012-12-12 22:18:26]

Something went wrong while uploading. Please run "hg upload" again.

[francesc, 2012-12-12 22:30:55]

On 2012/12/12 22:18:26, adg wrote:
> Something went wrong while uploading. Please run "hg upload" again.

Done

[adg, 2012-12-13 02:47:26]

LGTM modulo one change

https://codereview.appspot.com/6933049/diff/2006/present/templates/action.tmpl
File present/templates/action.tmpl (right):

https://codereview.appspot.com/6933049/diff/2006/present/templates/action.tmp...
present/templates/action.tmpl:37: </div>{{end}}
put the end on the next line

[francesc, 2012-12-13 02:51:14]

*** Submitted as
https://code.google.com/p/go/source/detail?r=598a884f5100&repo=talks ***

go.talks/pkg/present: fix image size handling.

Fixes issue 4527

R=adg
CC=golang-dev
https://codereview.appspot.com/6933049

https://codereview.appspot.com/6933049/diff/2006/present/templates/action.tmpl
File present/templates/action.tmpl (right):

https://codereview.appspot.com/6933049/diff/2006/present/templates/action.tmp...
present/templates/action.tmpl:37: </div>{{end}}
On 2012/12/13 02:47:27, adg wrote:
> put the end on the next line

Done.