Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(236)

Issue 6932054: code review 6932054: sort: add Reverse as a function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by Miek Gieben
Modified:
11 years, 1 month ago
Reviewers:
minux1, rsc
CC:
golang-dev
Visibility:
Public.

Description

sort: add Reverse as a function This updates: https://codereview.appspot.com/6909059/ Fixes issue 4511.

Patch Set 1 #

Patch Set 2 : diff -r 11d696585699 https://code.google.com/p/go/ #

Total comments: 6

Patch Set 3 : diff -r 8d4bd93dcd41 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8d4bd93dcd41 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M src/pkg/sort/example_test.go View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/sort/sort.go View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M src/pkg/sort/sort_test.go View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9
minux1
https://codereview.appspot.com/6932054/diff/1001/src/pkg/sort/example_reverse_test.go File src/pkg/sort/example_reverse_test.go (left): https://codereview.appspot.com/6932054/diff/1001/src/pkg/sort/example_reverse_test.go#oldcode25 src/pkg/sort/example_reverse_test.go:25: func ExampleInterface_reverse() { I think the name should be ...
11 years, 3 months ago (2012-12-21 16:28:25 UTC) #1
rsc
I think the implementation plus an example test is probably fine. The three tests are ...
11 years, 3 months ago (2012-12-21 21:25:23 UTC) #2
rsc
Ping.
11 years, 1 month ago (2013-01-31 17:11:04 UTC) #3
rsc
Ping.
11 years, 1 month ago (2013-01-31 17:11:08 UTC) #4
Miek Gieben
Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2013-02-01 13:07:44 UTC) #5
Miek Gieben
Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-02-01 13:17:00 UTC) #6
rsc
LGTM
11 years, 1 month ago (2013-02-01 16:42:35 UTC) #7
rsc
I submitted this but the network failed at sending the mail. Miek, you'll have to ...
11 years, 1 month ago (2013-02-01 18:01:58 UTC) #8
Miek Gieben
11 years, 1 month ago (2013-02-01 18:03:06 UTC) #9
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b