code review 69280043: net/http: make Transport.CancelRequest work for request...

net/http: make Transport.CancelRequest work for requests blocked in a dial

Fixes Issue 6951

[bradfitz, 2014-02-27 00:45:55]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[josharian, 2014-02-27 16:24:05]

Running the test in a loop with large GOMAXPROCS, I see rare (1 in 20?)
failures:

$ go test -c net/http
$ while true; do sleep 1; GOMAXPROCS=8 ./http.test
-test.run=CancelRequestInDial; done

PASS
--- FAIL: TestTransportCancelRequestInDial-8 (5.01 seconds)
	transport_test.go:1367: timeout; cancel didn't work?
PASS

https://codereview.appspot.com/69280043/diff/40001/src/pkg/net/http/transport.go
File src/pkg/net/http/transport.go (right):

https://codereview.appspot.com/69280043/diff/40001/src/pkg/net/http/transport...
src/pkg/net/http/transport.go:478: // Our dial finished. (or was canceled)
Nit: s/.//

[bradfitz, 2014-02-27 20:40:13]

Hello golang-codereviews@googlegroups.com, josharian@gmail.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[bradfitz, 2014-02-27 20:40:36]

PTAL. I could reproduce the test hang and have fixed it.



On Thu, Feb 27, 2014 at 12:40 PM, <bradfitz@golang.org> wrote:

> Hello golang-codereviews@googlegroups.com, josharian@gmail.com (cc:
> golang-codereviews@googlegroups.com),
>
> Please take another look.
>
>
> https://codereview.appspot.com/69280043/
>

[josharian, 2014-02-27 21:22:40]

LGTM

[bradfitz, 2014-02-27 21:32:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=1af6f530098f ***

net/http: make Transport.CancelRequest work for requests blocked in a dial

Fixes Issue 6951

LGTM=josharian
R=golang-codereviews, josharian
CC=golang-codereviews
https://codereview.appspot.com/69280043

[gobot, 2014-02-27 21:35:47]

This CL appears to have broken the solaris-amd64-solaris11 builder.