Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(788)

Issue 69260045: code review 69260045: go/printer: measure lines/construct in generated output... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by gri
Modified:
10 years, 1 month ago
Reviewers:
gobot, adonovan
CC:
golang-codereviews, adonovan
Visibility:
Public.

Description

go/printer: measure lines/construct in generated output rather than incoming source No change to $GOROOT/src, misc formatting. Nice side-effect: almost 3% faster runs because it's much faster to compute line number differences in the generated output than the incoming source. Benchmark run, best of 5 runs, before and after: BenchmarkPrint 200 12347587 ns/op BenchmarkPrint 200 11999061 ns/op Fixes issue 4504.

Patch Set 1 #

Patch Set 2 : diff -r b7298e3e7773 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b7298e3e7773 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Patch Set 5 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Patch Set 6 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Patch Set 7 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Patch Set 8 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Patch Set 9 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Patch Set 10 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Total comments: 4

Patch Set 11 : diff -r c9d0aafffe33 https://code.google.com/p/go/ #

Patch Set 12 : diff -r c9d0aafffe33 https://code.google.com/p/go/ #

Patch Set 13 : diff -r c9d0aafffe33 https://code.google.com/p/go/ #

Patch Set 14 : diff -r 9d51d21e0ac6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -40 lines) Patch
M src/pkg/go/printer/nodes.go View 1 2 3 4 5 6 7 8 9 10 11 12 9 chunks +25 lines, -31 lines 0 comments Download
M src/pkg/go/printer/printer.go View 1 2 3 4 5 6 7 8 9 4 chunks +34 lines, -9 lines 0 comments Download
M src/pkg/go/printer/testdata/comments2.golden View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/comments2.input View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/declarations.golden View 1 2 3 4 5 6 7 1 chunk +15 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/declarations.input View 1 2 3 4 5 6 7 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6
gri
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 1 month ago (2014-02-27 00:57:26 UTC) #1
adonovan
LGTM Seems fine, but I'm not an expert on this code. https://codereview.appspot.com/69260045/diff/160001/src/pkg/go/printer/nodes.go File src/pkg/go/printer/nodes.go (right): ...
10 years, 1 month ago (2014-02-27 18:53:14 UTC) #2
gri
PTAL https://codereview.appspot.com/69260045/diff/160001/src/pkg/go/printer/nodes.go File src/pkg/go/printer/nodes.go (right): https://codereview.appspot.com/69260045/diff/160001/src/pkg/go/printer/nodes.go#newcode923 src/pkg/go/printer/nodes.go:923: if _, ok := s.(*ast.LabeledStmt); ok { On ...
10 years, 1 month ago (2014-02-27 19:30:30 UTC) #3
adonovan
LGTM On 2014/02/27 19:30:30, gri wrote: > PTAL > > https://codereview.appspot.com/69260045/diff/160001/src/pkg/go/printer/nodes.go > File src/pkg/go/printer/nodes.go (right): ...
10 years, 1 month ago (2014-02-27 19:34:45 UTC) #4
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=946dbec17445 *** go/printer: measure lines/construct in generated output rather than incoming source ...
10 years, 1 month ago (2014-02-27 19:36:02 UTC) #5
gobot
10 years, 1 month ago (2014-02-27 19:50:38 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the windows-386-ec2 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b