Issue 6923046: code review 6923046: net: TestDialTimeoutFDLeak failure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6923046: code review 6923046: net: TestDialTimeoutFDLeak failure (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dfc

Modified:
11 years, 4 months ago

Reviewers:

CC:
albert.strasheim, rsc, golang-dev

Visibility:
Public.

Description

net: TestDialTimeoutFDLeak failure Fixes issue 4384. Implments the suggestion by rsc in comment 15, http://code.google.com/p/go/issues/detail?id=4384#c15 An alternate suggestion would be to temporarily set GOMAXPROCS to 1 during this test.

Patch Set 1 #

Patch Set 2 : diff -r 3c932286e5f5 https://code.google.com/p/go #

Patch Set 3 : diff -r 3c932286e5f5 https://code.google.com/p/go #

Patch Set 4 : diff -r 2888e5323790 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/net/dial_test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

albert.strasheim

LGTM Ran the test a few thousand times. Increasing the limit works without having to ...

11 years, 4 months ago (2012-12-11 06:12:58 UTC) #1

dfc

Hello fullung@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2012-12-11 06:13:56 UTC) #2

dfc

11 years, 4 months ago (2012-12-11 20:25:31 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=ec3ae5b98922 ***

net: TestDialTimeoutFDLeak failure

Fixes issue 4384.

Implments the suggestion by rsc in comment 15,
http://code.google.com/p/go/issues/detail?id=4384#c15

An alternate suggestion would be to temporarily set GOMAXPROCS to 1 during this
test.

R=fullung, rsc
CC=golang-dev
https://codereview.appspot.com/6923046

Expand All Messages | Collapse All Messages