Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 6922048: code review 6922048: cmd/{5,6,8}g: reduce size of Prog and Addr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by dave
Modified:
12 years, 3 months ago
Reviewers:
CC:
rsc, minux1, golang-dev
Visibility:
Public.

Description

cmd/{5,6,8}g: reduce size of Prog and Addr 5g: Prog went from 128 bytes to 88 bytes 6g: Prog went from 174 bytes to 144 bytes 8g: Prog went from 124 bytes to 92 bytes There may be a little more that can be squeezed out of Addr, but alignment will be a factor. All: remove the unused pun field from Addr

Patch Set 1 #

Patch Set 2 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Patch Set 3 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Patch Set 4 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Patch Set 5 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Patch Set 6 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Total comments: 6

Patch Set 7 : diff -r 8b89b6326704 https://code.google.com/p/go #

Patch Set 8 : diff -r 8b89b6326704 https://code.google.com/p/go #

Patch Set 9 : diff -r 8ea9d438b64e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -97 lines) Patch
M src/cmd/5g/gg.h View 1 2 3 4 5 6 2 chunks +12 lines, -9 lines 0 comments Download
M src/cmd/5g/gobj.c View 1 5 chunks +7 lines, -7 lines 0 comments Download
M src/cmd/5g/gsubr.c View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/5g/list.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/cmd/5g/reg.c View 1 6 chunks +10 lines, -10 lines 0 comments Download
M src/cmd/6g/gg.h View 1 2 3 4 5 6 2 chunks +7 lines, -4 lines 0 comments Download
M src/cmd/6g/gobj.c View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M src/cmd/6g/gsubr.c View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/6g/list.c View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/cmd/6g/peep.c View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6g/reg.c View 1 2 3 6 chunks +10 lines, -10 lines 0 comments Download
M src/cmd/8g/gg.h View 1 2 3 4 5 6 2 chunks +6 lines, -4 lines 0 comments Download
M src/cmd/8g/gobj.c View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M src/cmd/8g/gsubr.c View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/8g/list.c View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/8g/peep.c View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8g/reg.c View 1 2 6 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8
rsc
hg mail it but it looks good to me https://codereview.appspot.com/6922048/diff/25/src/cmd/5g/gg.h File src/cmd/5g/gg.h (right): https://codereview.appspot.com/6922048/diff/25/src/cmd/5g/gg.h#newcode20 src/cmd/5g/gg.h:20: ...
12 years, 3 months ago (2012-12-12 04:07:28 UTC) #1
dave_cheney.net
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2012-12-12 23:01:08 UTC) #2
dave_cheney.net
https://codereview.appspot.com/6922048/diff/25/src/cmd/5g/gg.h File src/cmd/5g/gg.h (right): https://codereview.appspot.com/6922048/diff/25/src/cmd/5g/gg.h#newcode20 src/cmd/5g/gg.h:20: double dval; On 2012/12/12 04:07:28, rsc wrote: > Please ...
12 years, 3 months ago (2012-12-13 00:23:16 UTC) #3
rsc
LGTM
12 years, 3 months ago (2012-12-13 02:45:50 UTC) #4
minux1
you also reduced the size of Addr, please consider update the description.
12 years, 3 months ago (2012-12-13 11:05:38 UTC) #5
dave_cheney.net
On 2012/12/13 11:05:38, minux wrote: > you also reduced the size of Addr, please consider ...
12 years, 3 months ago (2012-12-13 11:09:06 UTC) #6
minux1
LGTM.
12 years, 3 months ago (2012-12-13 12:07:16 UTC) #7
dave_cheney.net
12 years, 3 months ago (2012-12-13 19:20:40 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=43afb4e714ad ***

cmd/{5,6,8}g: reduce size of Prog and Addr

5g: Prog went from 128 bytes to 88 bytes
6g: Prog went from 174 bytes to 144 bytes
8g: Prog went from 124 bytes to 92 bytes

There may be a little more that can be squeezed out of Addr, but alignment will
be a factor.

All: remove the unused pun field from Addr

R=rsc, minux.ma
CC=golang-dev
https://codereview.appspot.com/6922048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b