Issue 6920046: code review 6920046: exp/types: filling in more blanks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6920046: code review 6920046: exp/types: filling in more blanks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by gri

Modified:
12 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

exp/types: filling in more blanks - implemented built-in complex() - implemented missing expression switch checks

Patch Set 2 : diff -r 7b9e9fc59eb5 https://code.google.com/p/go #

Patch Set 3 : diff -r 7b9e9fc59eb5 https://code.google.com/p/go #

Patch Set 4 : diff -r 7b9e9fc59eb5 https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r 0ce7955e8881 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -21 lines)			Patch
M	src/pkg/exp/gotype/gotype_test.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/types/builtins.go	View	1	2 chunks	+48 lines, -2 lines	0 comments	Download
M	src/pkg/exp/types/const.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/pkg/exp/types/stmt.go	View	1 2 3 4	1 chunk	+44 lines, -11 lines	0 comments	Download
M	src/pkg/exp/types/testdata/builtins.src	View	1	1 chunk	+27 lines, -4 lines	0 comments	Download
M	src/pkg/exp/types/testdata/stmt0.src	View	1 2	1 chunk	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2012-12-11 06:02:19 UTC) #1

rsc

LGTM https://codereview.appspot.com/6920046/diff/2002/src/pkg/exp/types/stmt.go File src/pkg/exp/types/stmt.go (right): https://codereview.appspot.com/6920046/diff/2002/src/pkg/exp/types/stmt.go#newcode452 src/pkg/exp/types/stmt.go:452: // If we have a constant integer case ...

12 years, 3 months ago (2012-12-11 17:43:27 UTC) #2

gri

https://codereview.appspot.com/6920046/diff/2002/src/pkg/exp/types/stmt.go File src/pkg/exp/types/stmt.go (right): https://codereview.appspot.com/6920046/diff/2002/src/pkg/exp/types/stmt.go#newcode452 src/pkg/exp/types/stmt.go:452: // If we have a constant integer case value, ...

12 years, 3 months ago (2012-12-11 18:00:24 UTC) #3

gri

12 years, 3 months ago (2012-12-11 18:18:58 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=13a4979ed5cb ***

exp/types: filling in more blanks

- implemented built-in complex()
- implemented missing expression switch checks

R=rsc
CC=golang-dev
https://codereview.appspot.com/6920046

Expand All Messages | Collapse All Messages