code review 68990045: go-tour: fix bug for multiple file handling

go-tour: fix bug for multiple file handling

Explanation: the scope in the view inherits from the one on the controller, therefore reading a field works, but not modifying it.

[francesc, 2014-02-27 00:02:47]

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go-tour

[adg, 2014-02-27 00:03:44]

LGTM

you read my mind. I was just playing with this and wondering why it wasn't
working.

On Thursday, 27 February 2014, <campoy@golang.org> wrote:

> Reviewers: adg,
>
> Message:
> Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go-tour
>
>
> Description:
> go-tour: fix bug for multiple file handling
>
> Explanation: the scope in the view inherits from the one on the
> controller, therefore reading a field works, but not modifying it.
>
> Please review this at https://codereview.appspot.com/68990045/
>
> Affected files (+4, -1 lines):
>   M static/js/controllers.js
>   M static/partials/editor.html
>
>
> Index: static/js/controllers.js
> ===================================================================
> --- a/static/js/controllers.js
> +++ b/static/js/controllers.js
> @@ -42,6 +42,9 @@
>              }
>              $location.path('/' + l + '/' + page);
>          }
> +        $scope.openFile = function(file) {
> +            $scope.curFile = file;
> +        }
>
>          function log(mode, text) {
>              $(".output.active").html('<pre class="' + mode + '">' + text
> + '</pre>');
> Index: static/partials/editor.html
> ===================================================================
> --- a/static/partials/editor.html
> +++ b/static/partials/editor.html
> @@ -15,7 +15,7 @@
>
>          <div id="left-side" class="relative-content">
>              <div id="explorer" ng-class="{hidden:
> TOC.lessons[lessonId].Pages[curPage-1].Files.length==0}">
> -                <a class="menu-button" ng-repeat="f in
> TOC.lessons[lessonId].Pages[curPage-1].Files" ng-click="curFile = $index"
> ng-class="{active: $index==curFile}">{{f.Name}}</a>
> +                <a class="menu-button" ng-repeat="f in
> TOC.lessons[lessonId].Pages[curPage-1].Files" ng-click="openFile($index)"
> ng-class="{active: $index==curFile}">{{f.Name}}</a>
>              </div>
>
>              <div class="relative-content" ng-class="{hidden:
> TOC.lessons[lessonId].Pages[curPage-1].Files.length==0}">
>
>
>

[francesc, 2014-02-27 00:17:29]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=d088440afaf2
***

go-tour: fix bug for multiple file handling

Explanation: the scope in the view inherits from the one on the controller,
therefore reading a field works, but not modifying it.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/68990045