syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX

syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX 
    
Fixes Issue 7415

[bradfitz, 2014-02-26 17:58:42]

This CL reverts unsafe.Pointer back to uintptrs.  How did you generate it?

[worr, 2014-02-26 18:20:54]

On 2014/02/26 17:58:42, bradfitz wrote:
> This CL reverts unsafe.Pointer back to uintptrs.  How did you generate it?

I built it with mkall.sh with golang 1.2

[bradfitz, 2014-02-26 18:23:40]

Please use the mkall.sh from tip.  I'm guessing that is the problem.



On Wed, Feb 26, 2014 at 10:20 AM, <ay1244@gmail.com> wrote:

> Reviewers: bradfitz,
>
> Message:
>
> On 2014/02/26 17:58:42, bradfitz wrote:
>
>> This CL reverts unsafe.Pointer back to uintptrs.  How did you generate
>>
> it?
>
> I built it with mkall.sh with golang 1.2
>
> Description:
> Add mlock, munlock, mlockall, munlockall and mprotect to OSX
>
> Please review this at https://codereview.appspot.com/68980043/
>
> Affected files (+153, -12 lines):
>   M src/pkg/syscall/syscall_darwin.go
>   M src/pkg/syscall/zsyscall_darwin_386.go
>   M src/pkg/syscall/zsyscall_darwin_amd64.go
>
>
>

[worr, 2014-02-27 02:14:16]

On 2014/02/26 18:23:40, bradfitz wrote:
> Please use the mkall.sh from tip.  I'm guessing that is the problem.
> 
> 
> 
> On Wed, Feb 26, 2014 at 10:20 AM, <mailto:ay1244@gmail.com> wrote:
> 
> > Reviewers: bradfitz,
> >
> > Message:
> >
> > On 2014/02/26 17:58:42, bradfitz wrote:
> >
> >> This CL reverts unsafe.Pointer back to uintptrs.  How did you generate
> >>
> > it?
> >
> > I built it with mkall.sh with golang 1.2
> >
> > Description:
> > Add mlock, munlock, mlockall, munlockall and mprotect to OSX
> >
> > Please review this at https://codereview.appspot.com/68980043/
> >
> > Affected files (+153, -12 lines):
> >   M src/pkg/syscall/syscall_darwin.go
> >   M src/pkg/syscall/zsyscall_darwin_386.go
> >   M src/pkg/syscall/zsyscall_darwin_amd64.go
> >
> >
> >

I've updated after using the proper mkall.sh.

[bradfitz, 2014-02-27 03:34:37]

LGTM

[bradfitz, 2014-02-27 03:37:23]

Before we can accept this, do two things:

1) Submit a CLA. See: http://golang.org/doc/contribute.html#copyright and let us
know when you've done it.

2) Fix the commit message to be:

   syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX

   Fixes Issue 7415

(Note the first line starts with "syscall: ", then a blank line, then the magic
phrase "Fixes Issue nnnnn" which our scripts recognize to close the bug)

[worr, 2014-02-27 04:11:14]

syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX

Fixes Issue 7415

[worr, 2014-02-27 04:12:22]

Signed the CLA yesterday. Should be all set.

[bradfitz, 2014-02-27 04:13:09]

Please update the CL description first.

Run "hg change 68980043" and edit it.

[bradfitz, 2014-02-27 04:14:26]

I see no record of your CLA submission.

Under what email address did you submit it, or did you mail/fax/carrier pigeon
it in?

[worr, 2014-02-27 04:18:03]

On 2014/02/27 04:14:26, bradfitz wrote:
> I see no record of your CLA submission.
> 
> Under what email address did you submit it, or did you mail/fax/carrier pigeon
> it in?

It's under will@worrbase.com, since that's typically the email I want attached
to my contributions. Does it need to be under my gmail.com address?

[worr, 2014-02-27 05:01:33]

On 2014/02/27 04:13:09, bradfitz wrote:
> Please update the CL description first.
> 
> Run "hg change 68980043" and edit it.

I made this code review with upload.py initially, since that was what I've used
for other projects that use rietveld.

I got the mercurial plugin, re-cloned the repo and have imported the change
list, but now hg change, while showing that I've updated the description,
doesn't seem to push that to the server. I've already logged in with hg
code-login.

[iant, 2014-02-27 05:02:44]

On Wed, Feb 26, 2014 at 9:01 PM,  <ay1244@gmail.com> wrote:
> On 2014/02/27 04:13:09, bradfitz wrote:
>>
>> Please update the CL description first.
>
>
>> Run "hg change 68980043" and edit it.
>
>
> I made this code review with upload.py initially, since that was what
> I've used for other projects that use rietveld.
>
> I got the mercurial plugin, re-cloned the repo and have imported the
> change list, but now hg change, while showing that I've updated the
> description, doesn't seem to push that to the server. I've already
> logged in with hg code-login.

Does an "hg upload" help?

You may have to edit the description on the web site.

Ian

[worr, 2014-02-27 05:06:27]

On 2014/02/27 05:02:44, iant wrote:
> On Wed, Feb 26, 2014 at 9:01 PM,  <mailto:ay1244@gmail.com> wrote:
> > On 2014/02/27 04:13:09, bradfitz wrote:
> >>
> >> Please update the CL description first.
> >
> >
> >> Run "hg change 68980043" and edit it.
> >
> >
> > I made this code review with upload.py initially, since that was what
> > I've used for other projects that use rietveld.
> >
> > I got the mercurial plugin, re-cloned the repo and have imported the
> > change list, but now hg change, while showing that I've updated the
> > description, doesn't seem to push that to the server. I've already
> > logged in with hg code-login.
> 
> Does an "hg upload" help?
> 
> You may have to edit the description on the web site.
> 
> Ian

I've just updated it on the website. I'll make sure to use the official tools
next time. Thanks for the help!

[bradfitz, 2014-02-27 18:13:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=c9d0aafffe33 ***

syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX

Fixes Issue 7415

LGTM=bradfitz
R=bradfitz, iant
CC=golang-codereviews
https://codereview.appspot.com/68980043

Committer: Brad Fitzpatrick <bradfitz@golang.org>