code review 68920045: crypto/tls: add DialWithDialer.

crypto/tls: add DialWithDialer.

While reviewing uses of the lower-level Client API in code, I found
that in many cases, code was using Client only because it needed a
timeout on the connection. DialWithDialer allows a timeout (and
 other values) to be specified without resorting to the low-level API.

[agl1, 2014-02-26 18:17:04]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-02-26 21:43:30]

LGTM

[bradfitz, 2014-02-26 21:53:02]

https://codereview.appspot.com/68920045/diff/50001/src/pkg/crypto/tls/tls.go
File src/pkg/crypto/tls/tls.go (right):

https://codereview.appspot.com/68920045/diff/50001/src/pkg/crypto/tls/tls.go#...
src/pkg/crypto/tls/tls.go:105: errChannel <- errors.New("tls: DialWithDialer
timed out")
this error doesn't implement the net.Error interface.  It should be Temporary
and Timeout.

[agl1, 2014-02-28 14:40:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=3d37606fb793 ***

crypto/tls: add DialWithDialer.

While reviewing uses of the lower-level Client API in code, I found
that in many cases, code was using Client only because it needed a
timeout on the connection. DialWithDialer allows a timeout (and
 other values) to be specified without resorting to the low-level API.

LGTM=r
R=golang-codereviews, r, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/68920045

https://codereview.appspot.com/68920045/diff/50001/src/pkg/crypto/tls/tls.go
File src/pkg/crypto/tls/tls.go (right):

https://codereview.appspot.com/68920045/diff/50001/src/pkg/crypto/tls/tls.go#...
src/pkg/crypto/tls/tls.go:105: errChannel <- errors.New("tls: DialWithDialer
timed out")
On 2014/02/26 21:53:02, bradfitz wrote:
> this error doesn't implement the net.Error interface.  It should be Temporary
> and Timeout.

Done.

[gobot, 2014-02-28 14:46:40]

This CL appears to have broken the freebsd-amd64 builder.

[agl1, 2014-02-28 14:51:40]

On Fri, Feb 28, 2014 at 9:46 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the freebsd-amd64 builder.

Seems unlikely:

"--- FAIL: TestFinalizerInterfaceBig-2 (4.04 seconds)

mfinal_test.go:98: finalizer for type *bigValue didn't run"


Cheers

AGL