code review 68820044: [release-branch.go1.2] database/sql: Use all connection...

[release-branch.go1.2] database/sql: Use all connections in pool

««« CL 40410043 / 8a7ac002f840
database/sql: Use all connections in pool

The last connection in the pool was not being handed out correctly.

R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/40410043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
»»»

[rsc, 2014-02-28 01:47:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2014-02-28 01:50:38]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[r, 2014-02-28 03:09:35]

LGTM

[rsc, 2014-02-28 03:43:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=2869b3245f8d ***

[release-branch.go1.2] database/sql: Use all connections in pool

««« CL 40410043 / 8a7ac002f840
database/sql: Use all connections in pool

The last connection in the pool was not being handed out correctly.

R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/40410043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
»»»

LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://codereview.appspot.com/68820044

[gobot, 2014-02-28 03:45:35]

This CL appears to have broken the solaris-amd64-solaris11 builder.

[dave_cheney.net, 2014-02-28 03:47:06]

Ignore, the solaris builder cannot build go 1.2 versions.


On Fri, Feb 28, 2014 at 2:45 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the solaris-amd64-solaris11 builder.
>
>
> https://codereview.appspot.com/68820044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>