Issue 6872055: code review 6872055: net/http: clarify that Request.Host may contain a port ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6872055: code review 6872055: net/http: clarify that Request.Host may contain a port ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bradfitz

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

net/http: clarify that Request.Host may contain a port number Fixes issue 4172

Patch Set 2 : diff -r 1f3ebf9a7548 https://code.google.com/p/go #

Patch Set 3 : diff -r 1f3ebf9a7548 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 95aad98ed035 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
M	src/pkg/net/http/request.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/net/http/request_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/net/url/url.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2012-12-03 23:49:11 UTC) #1

dsymonds

LGTM https://codereview.appspot.com/6872055/diff/2002/src/pkg/net/http/request.go File src/pkg/net/http/request.go (right): https://codereview.appspot.com/6872055/diff/2002/src/pkg/net/http/request.go#newcode127 src/pkg/net/http/request.go:127: // It may of the form "host:port". "It ...

11 years, 5 months ago (2012-12-03 23:58:15 UTC) #2

bradfitz

11 years, 5 months ago (2012-12-04 15:09:07 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ceac249082a8 ***

net/http: clarify that Request.Host may contain a port number

Fixes issue 4172

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/6872055

Expand All Messages | Collapse All Messages