Issue 6871056: code review 6871056: go.talks: don't display time on slides when time is zero

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6871056: code review 6871056: go.talks: don't display time on slides when time is zero (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by adg

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

go.talks: don't display time on slides when time is zero

Patch Set 2 : diff -r c0f111ea557b https://code.google.com/p/go.talks #

Patch Set 3 : diff -r c0f111ea557b https://code.google.com/p/go.talks #

Patch Set 4 : diff -r b9ff341e48ed https://code.google.com/p/go.talks #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	present/templates/slides.tmpl	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 5 months ago (2012-12-04 02:42:49 UTC) #1

dsymonds

https://codereview.appspot.com/6871056/diff/1/present/templates/slides.tmpl File present/templates/slides.tmpl (right): https://codereview.appspot.com/6871056/diff/1/present/templates/slides.tmpl#newcode19 present/templates/slides.tmpl:19: {{if .Time.IsZero}}{{else}}<h3>{{.Format "2 January 2006"}}</h3>{{end}} {{if not .Time.IsZero}} and ...

11 years, 5 months ago (2012-12-04 02:44:06 UTC) #2

adg

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 5 months ago (2012-12-04 02:44:52 UTC) #3

adg

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 5 months ago (2012-12-04 02:48:32 UTC) #5

adg

11 years, 5 months ago (2012-12-04 05:18:56 UTC) #6

*** Submitted as
https://code.google.com/p/go/source/detail?r=97a6c23bcdbf&repo=talks ***

go.talks: don't display time on slides when time is zero

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/6871056

Expand All Messages | Collapse All Messages