Issue 6865043: code review 6865043: crypto/tls: fix loading keys labeled just "PRIVATE KEY"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6865043: code review 6865043: crypto/tls: fix loading keys labeled just "PRIVATE KEY" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bradfitz

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, agl1

Visibility:
Public.

Description

crypto/tls: fix loading keys labeled just "PRIVATE KEY" Worked in Go 1, broken in f440e65f93fe. Fixes issue 4477

Patch Set 2 : diff -r 86eed47f9b5c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 86eed47f9b5c https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	src/pkg/crypto/tls/tls.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/crypto/tls/tls_test.go	View	1 2 3	2 chunks	+20 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-12-01 17:33:53 UTC) #1

agl1

https://codereview.appspot.com/6865043/diff/5001/src/pkg/crypto/tls/tls_test.go File src/pkg/crypto/tls/tls_test.go (right): https://codereview.appspot.com/6865043/diff/5001/src/pkg/crypto/tls/tls_test.go#newcode70 src/pkg/crypto/tls/tls_test.go:70: 06h5JRGUNB1X/Hwuw64uKW2GGJLVPPhoYMcg/ALWaW+d/t+DmV5xikwKssuFq4BzVQldyCXTXGgu7OC0AQCC/Y/+ODK3NFKlRi+AsG3VQDSV4tgHLqZBBus0S6pPcg1q stray change?

11 years, 5 months ago (2012-12-01 18:55:17 UTC) #2

bradfitz

11 years, 5 months ago (2012-12-01 19:00:41 UTC) #4

bradfitz

11 years, 5 months ago (2012-12-01 19:02:14 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=96b9b81083c3 ***

crypto/tls: fix loading keys labeled just "PRIVATE KEY"

Worked in Go 1, broken in f440e65f93fe.

Fixes issue 4477

R=golang-dev, agl
CC=golang-dev
https://codereview.appspot.com/6865043

Expand All Messages | Collapse All Messages