Issue 6863049: code review 6863049: go.talks/pkg/present: refactor to remove action templat...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6863049: code review 6863049: go.talks/pkg/present: refactor to remove action templat... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by adg

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

go.talks/pkg/present: refactor to remove action template functions Now the Parse function reads all source files (including included code files), and the template execution only renders templates. (Previously, the two stages were confused.)

Patch Set 1 #

Patch Set 2 : diff -r c0f111ea557b https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 97a6c23bcdbf https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 97a6c23bcdbf https://code.google.com/p/go.talks #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -121 lines)			Patch
M	pkg/present/code.go	View		4 chunks	+41 lines, -51 lines	0 comments	Download
M	pkg/present/html.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/present/image.go	View		1 chunk	+10 lines, -16 lines	0 comments	Download
M	pkg/present/link.go	View	1	2 chunks	+8 lines, -17 lines	0 comments	Download
M	pkg/present/parse.go	View	1	4 chunks	+22 lines, -21 lines	0 comments	Download
M	present/templates/action.tmpl	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	present/templates/article.tmpl	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	present/templates/slides.tmpl	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 5 months ago (2012-12-03 00:54:51 UTC) #1

dsymonds

LGTM It looks like there's still a fair amount of template.HTML abuse, but this CL ...

11 years, 5 months ago (2012-12-05 03:44:09 UTC) #2

adg

11 years, 5 months ago (2012-12-05 03:46:37 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=4de2599667fd&repo=talks ***

go.talks/pkg/present: refactor to remove action template functions

Now the Parse function reads all source files (including included
code files), and the template execution only renders templates.
(Previously, the two stages were confused.)

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/6863049

Expand All Messages | Collapse All Messages