code review 68630043: go/printer: refine handling of one-line functions

go/printer: refine handling of one-line functions

Functions that "fit" on one line and were on one
line in the original source are not broken up into
two lines anymore simply because they contain a comment.

- Fine-tuned use of separating blanks after /*-style comments, so:

( /* extra blank after this comment */ )
(a int /* no extra blank after this comment*/)

- Factored out comment state (from printer state) into commentInfo.
- No impact on $GOROOT/src, misc formatting.

Fixes issue 5543.

[gri, 2014-02-25 23:14:51]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-02-26 19:41:26]

https://codereview.appspot.com/68630043/diff/320001/src/pkg/go/printer/printe...
File src/pkg/go/printer/printer.go (right):

https://codereview.appspot.com/68630043/diff/320001/src/pkg/go/printer/printe...
src/pkg/go/printer/printer.go:42: noExtraBlank     pmode = 1 << iota // disables
extra blank after /*-style comment
can these not be negative true?

https://codereview.appspot.com/68630043/diff/320001/src/pkg/go/printer/printe...
src/pkg/go/printer/printer.go:714: if p.mode&noExtraBlank == 0 &&
... because statements like this are hard to understand.

[gri, 2014-02-26 19:55:37]

https://codereview.appspot.com/68630043/diff/320001/src/pkg/go/printer/printe...
File src/pkg/go/printer/printer.go (right):

https://codereview.appspot.com/68630043/diff/320001/src/pkg/go/printer/printe...
src/pkg/go/printer/printer.go:42: noExtraBlank     pmode = 1 << iota // disables
extra blank after /*-style comment
On 2014/02/26 19:41:26, r wrote:
> can these not be negative true?

I'd rather not in this case:

The normal case is an extra blank/line break. If I make them positive, then a)
the printer mode's default value is not the respective zero value anymore and
must be explicitly set (not too bad), and b) the place where this flag is used
is going to be using, say: enableExtraBlank to _disable_ the extra blank
(because the flag is toggled) - which is even more confusing.

I'm aware this is not optimal but I'd rather not fiddle with the flag mechanism
at this point.

[r, 2014-02-26 21:20:02]

LGTM

[gri, 2014-02-26 21:40:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=b7298e3e7773 ***

go/printer: refine handling of one-line functions

Functions that "fit" on one line and were on one
line in the original source are not broken up into
two lines anymore simply because they contain a comment.

- Fine-tuned use of separating blanks after /*-style comments, so:

( /* extra blank after this comment */ )
(a int /* no extra blank after this comment*/)

- Factored out comment state (from printer state) into commentInfo.
- No impact on $GOROOT/src, misc formatting.

Fixes issue 5543.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/68630043

[gobot, 2014-02-26 21:43:18]

This CL appears to have broken the solaris-amd64-solaris11 builder.