Issue 6862046: code review 6862046: spec: receiver types in method expressions can be paren...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6862046: code review 6862046: spec: receiver types in method expressions can be paren... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by gri

Modified:
12 years, 3 months ago

Reviewers:
quarnster

CC:
rsc, iant, r, ken2, golang-dev

Visibility:
Public.

Description

spec: receiver types in method expressions can be parenthesized Fixes issue 4457.

Patch Set 2 : diff -r 5eac1a2d6fc3 https://code.google.com/p/go #

Patch Set 3 : diff -r 5eac1a2d6fc3 https://code.google.com/p/go #

Patch Set 4 : diff -r 5eac1a2d6fc3 https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r 5eac1a2d6fc3 https://code.google.com/p/go #

Patch Set 6 : diff -r 992bfc985165 https://code.google.com/p/go #

Patch Set 7 : diff -r 992bfc985165 https://code.google.com/p/go #

Total comments: 2

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	doc/go_spec.html	View	1 2 3 4 5	2 chunks	+5 lines, -3 lines	2 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org, iant@golang.org, r@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...

12 years, 3 months ago (2012-12-05 23:05:45 UTC) #1

iant

LGTM https://codereview.appspot.com/6862046/diff/5002/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6862046/diff/5002/doc/go_spec.html#newcode3348 doc/go_spec.html:3348: (T).Mv(t, t) // receiver types in method expressions ...

12 years, 3 months ago (2012-12-05 23:50:29 UTC) #2

gri

*** Submitted as https://code.google.com/p/go/source/detail?r=c7fe6d0e90eb *** spec: receiver types in method expressions can be parenthesized Fixes ...

12 years, 3 months ago (2012-12-06 17:32:08 UTC) #5

quarnster

https://codereview.appspot.com/6862046/diff/7004/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6862046/diff/7004/doc/go_spec.html#newcode3362 doc/go_spec.html:3362: (T).Mv(t, t) Shouldn't this be "(T).Mv(t, 7)"?

12 years, 3 months ago (2012-12-06 20:05:00 UTC) #6

gri

12 years, 3 months ago (2012-12-06 20:11:42 UTC) #7

https://codereview.appspot.com/6862046/diff/7004/doc/go_spec.html
File doc/go_spec.html (right):

https://codereview.appspot.com/6862046/diff/7004/doc/go_spec.html#newcode3362
doc/go_spec.html:3362: (T).Mv(t, t)
On 2012/12/06 20:05:00, quarnster wrote:
> Shouldn't this be "(T).Mv(t, 7)"?
> 
good catch - will fix in the next spec CL

Expand All Messages | Collapse All Messages