code review 6858094: misc/dashboard/app: trim old builds from the history

misc/dashboard/app: trim old builds from the history

The dashboard is currently failing to store results of new builds for some keys, notable the go.codereview sub repository. This is causing the builders to mark the entire triggering commit as failed. With the help of David Symonds we think it is because the results value has breached the 1mb datastore limit on AppEngine.

[dsymonds, 2012-11-29 08:22:43]

https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
File misc/dashboard/app/build/build.go (right):

https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
misc/dashboard/app/build/build.go:132: com.ResultData =
trim(append(com.ResultData, r.Data()), maxResults)
I don't think it needs trimming, just de-duping.

[dave_cheney.net, 2012-11-29 08:24:13]

On 2012/11/29 08:22:43, dsymonds wrote:
>
https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
> File misc/dashboard/app/build/build.go (right):
> 
>
https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
> misc/dashboard/app/build/build.go:132: com.ResultData =
> trim(append(com.ResultData, r.Data()), maxResults)
> I don't think it needs trimming, just de-duping.

There are no duplicates.

[dsymonds, 2012-11-29 08:36:06]

LGTM

Seems reasonable, but let's wait for adg to sanity check it now that
your workaround got things unstuck. He should be back next week.

[dave_cheney.net, 2012-11-29 08:39:34]

+1 for waiting for adg. I don't have any way to test this change, nor
any way to deploying, both of which suggest I shouldn't be making it.

On Thu, Nov 29, 2012 at 7:36 PM, David Symonds <dsymonds@golang.org> wrote:
> LGTM
>
> Seems reasonable, but let's wait for adg to sanity check it now that
> your workaround got things unstuck. He should be back next week.

[dave_cheney.net, 2012-12-10 07:30:05]

Gentle ping.

On Thu, Nov 29, 2012 at 7:39 PM, Dave Cheney <dave@cheney.net> wrote:
> +1 for waiting for adg. I don't have any way to test this change, nor
> any way to deploying, both of which suggest I shouldn't be making it.
>
> On Thu, Nov 29, 2012 at 7:36 PM, David Symonds <dsymonds@golang.org> wrote:
>> LGTM
>>
>> Seems reasonable, but let's wait for adg to sanity check it now that
>> your workaround got things unstuck. He should be back next week.

[adg, 2013-02-05 02:41:15]

LGTM

https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
File misc/dashboard/app/build/build.go (right):

https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
misc/dashboard/app/build/build.go:132: com.ResultData =
trim(append(com.ResultData, r.Data()), maxResults)
On 2012/11/29 08:22:43, dsymonds wrote:
> I don't think it needs trimming, just de-duping.

Nope, it's not a deduping issue. This is just a list of all the commits for all
the builders... not really necessary.

[dave_cheney.net, 2013-02-05 02:45:56]

Feel free to steal this CL from me, you would be the one who has to deploy it. 

On 05/02/2013, at 13:41, adg@golang.org wrote:

> LGTM
> 
> 
>
https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
> File misc/dashboard/app/build/build.go (right):
> 
>
https://codereview.appspot.com/6858094/diff/2001/misc/dashboard/app/build/bui...
> misc/dashboard/app/build/build.go:132: com.ResultData =
> trim(append(com.ResultData, r.Data()), maxResults)
> On 2012/11/29 08:22:43, dsymonds wrote:
>> I don't think it needs trimming, just de-duping.
> 
> Nope, it's not a deduping issue. This is just a list of all the commits
> for all the builders... not really necessary.
> 
> https://codereview.appspot.com/6858094/

[dave_cheney.net, 2013-02-05 09:50:16]

Hello dsymonds@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-02-05 09:50:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=ec4982dfc0fc ***

misc/dashboard/app: trim old builds from the history

The dashboard is currently failing to store results of new builds for some keys,
notable the go.codereview sub repository. This is causing the builders to mark
the entire triggering commit as failed. With the help of David Symonds we think
it is because the results value has breached the 1mb datastore limit on
AppEngine.

R=dsymonds, adg
CC=golang-dev
https://codereview.appspot.com/6858094