code review 6853062: cmd/vet: report type and format specifier mismatch in P...

cmd/vet: report type and format specifier mismatch in Printf*.

Fixes issue 4404.

[u, 2012-11-17 01:39:55]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[u, 2012-11-17 01:42:31]

For now only basic literals are supported. It would be nice to add support for
more complex statements later on, for instance identifiers (false/true) and
statements such as 3+2i.

Any and all feedback is welcome.

cheers /u

[bradfitz, 2012-11-17 02:11:15]

Couldn't you use the new type checker instead?

On Fri, Nov 16, 2012 at 5:42 PM, <r.eklind.87@gmail.com> wrote:

> For now only basic literals are supported. It would be nice to add
> support for more complex statements later on, for instance identifiers
> (false/true) and statements such as 3+2i.
>
> Any and all feedback is welcome.
>
> cheers /u
>
>
https://codereview.appspot.**com/6853062/<https://codereview.appspot.com/6853...
>

[r, 2012-11-17 04:54:05]

Printf in Go is sufficiently rich that this is a hard problem to do
well. I agree with Brad that a proper solution to this requires the
type checker and probably a lot more code. I suggest you leave this
until the type checker is done.

-rob

[bradfitz, 2012-11-17 06:32:35]

On Fri, Nov 16, 2012 at 8:54 PM, Rob Pike <r@golang.org> wrote:

> Printf in Go is sufficiently rich that this is a hard problem to do
> well. I agree with Brad that a proper solution to this requires the
> type checker and probably a lot more code.


It might actually be less code, even.  I haven't looked at the type
checker.  From talking to Robert, though, it sounds like using it should be
easy.