Issue 6851129: code review 6851129: os: check only user attributes in TestStatDirModeExec

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6851129: code review 6851129: os: check only user attributes in TestStatDirModeExec (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by brainman

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

os: check only user attributes in TestStatDirModeExec Some have their system setup in a particular way, see http://golang.org/issue/4444#c3.

Patch Set 1 #

Patch Set 2 : diff -r 86eed47f9b5c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 86eed47f9b5c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 86eed47f9b5c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 86eed47f9b5c https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 86eed47f9b5c https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	src/pkg/os/os_test.go	View	1 2 3	1 chunk	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2012-11-30 03:20:31 UTC) #1

brainman

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 4 months ago (2012-11-30 04:11:58 UTC) #2

brainman

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 4 months ago (2012-11-30 05:10:21 UTC) #4

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=c15545810dcd *** os: check only user attributes in TestStatDirModeExec Some have their ...

11 years, 4 months ago (2012-11-30 05:10:54 UTC) #5

brainman

11 years, 4 months ago (2012-11-30 05:11:12 UTC) #6

Message was sent while issue was closed.

On 2012/11/30 05:10:21, brainman wrote:
> Hello mailto:golang-dev@googlegroups.com, mailto:bradfitz@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

Please, ignore. Wrong button. It is beer time.

Alex

Expand All Messages | Collapse All Messages