Issue 6843051: code review 6843051: go.talks/present: do not put line breaks at end of line...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6843051: code review 6843051: go.talks/present: do not put line breaks at end of line... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by r

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, francesc

Visibility:
Public.

Description

go.talks/present: do not put line breaks at end of line in articles Add a new template, "newline", that is a <br> for slides but a no-op in articles.

Patch Set 1 #

Patch Set 2 : diff -r b8eea95e35a3 https://code.google.com/p/go.talks #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	present/templates/action.tmpl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	present/templates/article.tmpl	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	present/templates/slides.tmpl	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 5 months ago (2012-11-13 21:00:00 UTC) #1

francesc

On 2012/11/13 21:00:00, r wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

11 years, 5 months ago (2012-11-13 21:56:05 UTC) #2

11 years, 5 months ago (2012-11-13 22:08:51 UTC) #3

*** Submitted as
http://code.google.com/p/go/source/detail?r=44382830d29e&repo=talks ***

go.talks/present: do not put line breaks at end of line in articles
Add a new template, "newline", that is a <br> for slides but a no-op
in articles.

R=golang-dev, campoy
CC=golang-dev
http://codereview.appspot.com/6843051

Expand All Messages | Collapse All Messages