Issue 68400043: code review 68400043: go/printer: fix alignment of comments in labeled statements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68400043: code review 68400043: go/printer: fix alignment of comments in labeled statements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by gri

Modified:
10 years, 2 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

go/printer: fix alignment of comments in labeled statements Does not change src, misc formatting. Fixes issue 5623.

Patch Set 1 #

Patch Set 2 : diff -r ba599658e88e https://code.google.com/p/go/ #

Patch Set 3 : diff -r ba599658e88e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 733fefb1deae https://code.google.com/p/go #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -3 lines)			Patch
M	src/pkg/go/printer/nodes.go	View	1	3 chunks	+15 lines, -2 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments2.golden	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments2.input	View	1	1 chunk	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 2 months ago (2014-02-25 00:07:00 UTC) #1

gri

10 years, 2 months ago (2014-02-25 03:18:13 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e56c848d6c75 ***

go/printer: fix alignment of comments in labeled statements

Does not change src, misc formatting.

Fixes issue 5623.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/68400043

Expand All Messages | Collapse All Messages