Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 68330046: code review 68330046: net/http: use TCP Keep-Alives on DefaultTransport's con... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by bradfitz
Modified:
10 years, 1 month ago
Reviewers:
crawshaw1
CC:
rsc, crawshaw1, golang-codereviews
Visibility:
Public.

Description

net/http: use TCP Keep-Alives on DefaultTransport's connections Update Issue 3362 Also set a 30 second timeout, instead of relying on the operating system's timeout, which if often but not always 3 minutes.

Patch Set 1 #

Patch Set 2 : diff -r 2788778097c8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2788778097c8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8cef243ea572 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/pkg/net/http/transport.go View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
bradfitz
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 1 month ago (2014-02-24 21:20:40 UTC) #1
crawshaw1
LGTM
10 years, 1 month ago (2014-02-24 23:18:21 UTC) #2
bradfitz
10 years, 1 month ago (2014-02-24 23:20:49 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=733fefb1deae ***

net/http: use TCP Keep-Alives on DefaultTransport's connections

Update Issue 3362

Also set a 30 second timeout, instead of relying on the
operating system's timeout, which if often but not always 3
minutes.

LGTM=crawshaw
R=rsc, crawshaw
CC=golang-codereviews
https://codereview.appspot.com/68330046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b