Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 68250043: code review 68250043: crypto/tls: report TLS version in ConnectionState. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by agl1
Modified:
10 years, 1 month ago
Reviewers:
minux1, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

crypto/tls: report TLS version in ConnectionState. Fixes issue 7231.

Patch Set 1 #

Patch Set 2 : diff -r d3d43f270632 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d3d43f270632 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d3d43f270632 https://code.google.com/p/go/ #

Patch Set 5 : diff -r d3d43f270632 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 6 : diff -r 67d2e1f2e287 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/pkg/crypto/tls/common.go View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/crypto/tls/conn.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7
agl1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 1 month ago (2014-02-24 18:29:53 UTC) #1
bradfitz
Could you update the comment to reference VersionSSL30, VersionTLS1[012] somehow? Otherwise one might think the ...
10 years, 1 month ago (2014-02-24 19:19:11 UTC) #2
agl1
On 2014/02/24 19:19:11, bradfitz wrote: > Could you update the comment to reference VersionSSL30, VersionTLS1[012] ...
10 years, 1 month ago (2014-02-24 22:41:42 UTC) #3
bradfitz
LGTM https://codereview.appspot.com/68250043/diff/2/src/pkg/crypto/tls/common.go File src/pkg/crypto/tls/common.go (right): https://codereview.appspot.com/68250043/diff/2/src/pkg/crypto/tls/common.go#newcode156 src/pkg/crypto/tls/common.go:156: Version uint16 // TLS version used by the ...
10 years, 1 month ago (2014-02-24 22:56:08 UTC) #4
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=8cef243ea572 *** crypto/tls: report TLS version in ConnectionState. Fixes issue 7231. LGTM=bradfitz ...
10 years, 1 month ago (2014-02-24 23:01:38 UTC) #5
minux1
will need to update go1.3.txt (also for the other tls API change).
10 years, 1 month ago (2014-02-25 04:20:40 UTC) #6
agl1
10 years, 1 month ago (2014-02-25 15:47:48 UTC) #7
On Mon, Feb 24, 2014 at 11:20 PM, minux <minux.ma@gmail.com> wrote:
> will need to update go1.3.txt (also for the other tls API change).

Good point. https://codereview.appspot.com/68600043


Cheers

AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b