Issue 6819060: code review 6819060: go-tour: don't reset code on slide change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6819060: code review 6819060: go-tour: don't reset code on slide change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by adg

Modified:
11 years, 6 months ago

Reviewers:
bradfitz

CC:
golang-dev

Visibility:
Public.

Description

go-tour: don't reset code on slide change

Patch Set 1 #

Patch Set 2 : diff -r c96f38076b38 https://code.google.com/p/go-tour #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	static/tour.js	View		1 chunk	+8 lines, -3 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

11 years, 6 months ago (2012-10-31 13:25:46 UTC) #1

adg

*** Submitted as http://code.google.com/p/go-tour/source/detail?r=644636efabe0 *** go-tour: don't reset code on slide change R=bradfitz CC=golang-dev http://codereview.appspot.com/6819060

11 years, 6 months ago (2012-10-31 13:26:01 UTC) #2

bradfitz

11 years, 6 months ago (2012-10-31 13:38:01 UTC) #3

LGTM

https://codereview.appspot.com/6819060/diff/3001/static/tour.js
File static/tour.js (right):

https://codereview.appspot.com/6819060/diff/3001/static/tour.js#newcode212
static/tour.js:212: if (data) {
If you're writing Govascript, as you seem to be, remember to not do the implicit
bool conversion:

  if (data != null) {

But if you're writing Javascript, this whole function can be just:

  return pageData[page] || false;

Expand All Messages | Collapse All Messages