Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2434)

Issue 6816072: code review 6816072: go.talks/present: separate actions from slide and artic... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by adg
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, francesc
Visibility:
Public.

Description

go.talks/present: separate actions from slide and article templates Also includes some CSS cleanups, and adds the ability to edit code in articles.

Patch Set 1 #

Patch Set 2 : diff -r e4324aff2715 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -142 lines) Patch
M present/parse.go View 3 chunks +8 lines, -7 lines 0 comments Download
M present/static/article.css View 3 chunks +36 lines, -57 lines 0 comments Download
A present/templates/action.tmpl View 1 chunk +36 lines, -0 lines 0 comments Download
M present/templates/article.tmpl View 2 chunks +1 line, -39 lines 0 comments Download
M present/templates/slides.tmpl View 2 chunks +1 line, -39 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
11 years, 6 months ago (2012-11-01 15:53:43 UTC) #1
francesc
On 2012/11/01 15:53:43, adg wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
11 years, 6 months ago (2012-11-01 16:00:08 UTC) #2
adg
When you template.ParseFiles("a", "b"), a block that's defined in "a" can be redefined in "b", ...
11 years, 6 months ago (2012-11-01 16:35:42 UTC) #3
francesc
On 2012/11/01 16:35:42, adg wrote: > When you template.ParseFiles("a", "b"), a block that's defined in ...
11 years, 6 months ago (2012-11-01 16:57:46 UTC) #4
francesc
11 years, 6 months ago (2012-11-01 16:58:41 UTC) #5
adg
11 years, 6 months ago (2012-11-01 17:02:23 UTC) #6
*** Submitted as
http://code.google.com/p/go/source/detail?r=c232a1e8b8f9&repo=talks ***

go.talks/present: separate actions from slide and article templates

Also includes some CSS cleanups, and adds the ability to edit code
in articles.

R=golang-dev, campoy
CC=golang-dev
http://codereview.appspot.com/6816072
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b