Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 6815044: code review 6815044: net: use read deadline in Accept on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by snaury
Modified:
11 years, 5 months ago
Reviewers:
CC:
golang-dev, brainman
Visibility:
Public.

Description

net: use read deadline in Accept on windows Fixes issue 4296.

Patch Set 1 #

Patch Set 2 : diff -r ab32e21a9e1c https://code.google.com/p/go/ #

Patch Set 3 : diff -r ab32e21a9e1c https://code.google.com/p/go/ #

Patch Set 4 : diff -r ab32e21a9e1c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M src/pkg/net/fd_windows.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/timeout_test.go View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7
snaury
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 5 months ago (2012-10-28 09:30:41 UTC) #1
dfc
On 2012/10/28 09:30:41, snaury wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
11 years, 5 months ago (2012-10-28 12:10:55 UTC) #2
snaury
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 5 months ago (2012-10-28 12:21:18 UTC) #3
dfc
On 2012/10/28 12:21:18, snaury wrote: > Hello mailto:golang-dev@googlegroups.com, mailto:dave@cheney.net (cc: > mailto:golang-dev@googlegroups.com), > > Please ...
11 years, 5 months ago (2012-10-28 14:59:08 UTC) #4
dfc
+brainman, please also consider the effect on, http://codereview.appspot.com/6604072/
11 years, 5 months ago (2012-10-28 16:10:42 UTC) #5
brainman
LGTM Thank you very much. I will submit it in a couple of days, unless ...
11 years, 5 months ago (2012-10-29 00:12:43 UTC) #6
brainman
11 years, 5 months ago (2012-10-30 22:58:13 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=650edb0b6fd4 ***

net: use read deadline in Accept on windows

Fixes issue 4296.

R=golang-dev, alex.brainman
CC=golang-dev
http://codereview.appspot.com/6815044

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b