Issue 6782136: code review 6782136: go-tour/gotour/solution: Adding alternative solution to...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782136: code review 6782136: go-tour/gotour/solution: Adding alternative solution to... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by francesc

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

go-tour/gotour/solution: Adding alternative solution to the image exercise.

Patch Set 1 #

Patch Set 2 : diff -r f486f33778cf https://code.google.com/p/go-tour/ #

Patch Set 3 : diff -r f486f33778cf https://code.google.com/p/go-tour/ #

Patch Set 4 : diff -r f486f33778cf https://code.google.com/p/go-tour/ #

Patch Set 5 : diff -r f486f33778cf https://code.google.com/p/go-tour/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -21 lines)			Patch
	M	gotour/solutions/image.go	View	1 2 3	1 chunk	+7 lines, -21 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

francesc

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour/

11 years, 5 months ago (2012-11-29 19:43:20 UTC) #1

adg

I'd prefer that this example just replace the existing image.go.

11 years, 5 months ago (2012-11-30 12:29:31 UTC) #2

francesc

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 5 months ago (2012-11-30 18:59:54 UTC) #3

francesc

11 years, 5 months ago (2012-12-01 19:00:43 UTC) #5

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=dcebd27953ee
***

go-tour/gotour/solution: Adding alternative solution to the image exercise.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6782136

Expand All Messages | Collapse All Messages