Issue 6782084: code review 6782084: spec: fix constant expression example

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782084: code review 6782084: spec: fix constant expression example (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by gri

Modified:
12 years, 4 months ago

Reviewers:

CC:
r, aam, golang-dev

Visibility:
Public.

Description

spec: fix constant expression example Fixes issue 4400.

Patch Set 2 : diff -r e3b461ffb386 https://code.google.com/p/go #

Patch Set 3 : diff -r e3b461ffb386 https://code.google.com/p/go #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	doc/go_spec.html	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 4 months ago (2012-11-17 00:49:55 UTC) #1

LGTM with added example http://codereview.appspot.com/6782084/diff/1/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6782084/diff/1/doc/go_spec.html#newcode3659 doc/go_spec.html:3659: const Θ float64 = 3/2 ...

12 years, 4 months ago (2012-11-17 00:54:54 UTC) #2

aam

On 2012/11/17 00:57:58, aam wrote: > Fixes issue 4400 oops, missed it in the description, ...

12 years, 4 months ago (2012-11-17 00:58:32 UTC) #4

gri

12 years, 4 months ago (2012-11-17 19:16:21 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=f5b22a4df675 ***

spec: fix constant expression example

Fixes issue 4400.

R=r, mirtchovski
CC=golang-dev
http://codereview.appspot.com/6782084

Expand All Messages | Collapse All Messages