Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 67750043: code review 67750043: go-tour: omit tour programs from normal builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by adg
Modified:
10 years, 2 months ago
Reviewers:
minux1
CC:
golang-codereviews, minux1
Visibility:
Public.

Description

go-tour: omit tour programs from normal builds This makes "go build code.google.com/p/go-tour/..." succeed.

Patch Set 1 #

Patch Set 2 : diff -r 6b033c682042 https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
M content/prog/tour/advanced-exercise-complex-cube-roots.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/array.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/basic-types.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/buffered-channels.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/channels.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/constants.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/default-selection.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/errors.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-equivalent-binary-trees.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-errors.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-fibonacci-closure.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-http-handlers.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-images.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-loops-and-functions.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-maps.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-rot-reader.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-slices.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exercise-web-crawler.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/exported-names.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/for.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/for-continued.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/for-is-gos-while.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/forever.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/function-closures.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/function-values.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/functions.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/functions-continued.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/goroutines.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/hello.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/if.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/if-and-else.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/if-with-a-short-statement.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/images.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/imports.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/interfaces.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/interfaces-are-satisfied-implicitly.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/making-slices.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/map-literals.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/map-literals-continued.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/maps.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/methods.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/methods-continued.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/methods-with-pointer-receivers.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/multiple-results.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/mutating-maps.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/named-results.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/nil-slices.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/numeric-constants.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/packages.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/pointers.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/range.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/range-and-close.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/range-continued.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/sandbox.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/select.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/short-variable-declarations.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/slices.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/slicing-slices.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/struct-fields.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/struct-literals.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/structs.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/switch.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/switch-evaluation-order.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/switch-with-no-condition.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/the-new-function.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/type-conversions.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/variables.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/variables-with-initializers.go View 1 chunk +2 lines, -0 lines 0 comments Download
M content/prog/tour/web-servers.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour
10 years, 2 months ago (2014-02-24 02:52:58 UTC) #1
minux1
LGTM.
10 years, 2 months ago (2014-02-24 03:24:06 UTC) #2
adg
10 years, 2 months ago (2014-02-24 03:28:41 UTC) #3 
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=bfb239965508
***

go-tour: omit tour programs from normal builds

This makes "go build code.google.com/p/go-tour/..." succeed.

LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/67750043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b