Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2575)

Issue 6774048: code review 6774048: go.talks: changes to "code that grows with grace" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by adg
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

go.talks: changes to "code that grows with grace"

Patch Set 1 #

Patch Set 2 : diff -r 51956b13eca8 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r c232a1e8b8f9 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r c232a1e8b8f9 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r c232a1e8b8f9 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r c232a1e8b8f9 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -31 lines) Patch
M 2012/chat.slide View 1 2 3 5 chunks +51 lines, -22 lines 0 comments Download
A 2012/chat/both/chat.go View 1 2 1 chunk +117 lines, -0 lines 0 comments Download
A 2012/chat/both/html.go View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A 2012/chat/both/markov.go View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
A 2012/chat/http-noembed/chat.go View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A 2012/chat/http-noembed/html.go View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
M 2012/chat/http/chat.go View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M 2012/chat/markov/chat.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2012/chat/support/embed.go View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M 2012/chat/support/websocket.go View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M 2012/chat/support/websocket.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
11 years, 6 months ago (2012-11-03 10:50:03 UTC) #1
bradfitz
LGTM .... having just watched this evolution in two showings. On Sat, Nov 3, 2012 ...
11 years, 6 months ago (2012-11-03 12:01:34 UTC) #2
adg
11 years, 6 months ago (2012-11-03 16:37:38 UTC) #3
*** Submitted as
http://code.google.com/p/go/source/detail?r=f1f8b70d0de4&repo=talks ***

go.talks: changes to "code that grows with grace"

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6774048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b