Issue 6759053: code review 6759053: runtime: switch to 64-bit goroutine ids

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6759053: code review 6759053: runtime: switch to 64-bit goroutine ids (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by dvyukov

Modified:
12 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: switch to 64-bit goroutine ids Fixes issue 4275.

Patch Set 1 #

Patch Set 2 : diff -r b685816af832 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b685816af832 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d81bcf447d65 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/traceback_arm.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/traceback_x86.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 5 months ago (2012-10-25 12:13:26 UTC) #1

dvyukov

Can it affect gdb support? The race detector does not care because it has internal ...

12 years, 5 months ago (2012-10-25 12:15:34 UTC) #2

dvyukov

12 years, 5 months ago (2012-10-26 06:13:52 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=a88b24459ad8 ***

runtime: switch to 64-bit goroutine ids
Fixes issue 4275.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6759053

Expand All Messages | Collapse All Messages