Descriptionencoding/binary: skip blank fields when (en/de)coding structs
- minor unrelated cleanups
- performance impact in the noise
benchmark old ns/op new ns/op delta
BenchmarkReadSlice1000Int32s 83462 83346 -0.14%
BenchmarkReadStruct 4141 4247 +2.56%
BenchmarkReadInts 1588 1586 -0.13%
BenchmarkWriteInts 1550 1489 -3.94%
BenchmarkPutUvarint32 39 39 +1.02%
BenchmarkPutUvarint64 142 144 +1.41%
benchmark old MB/s new MB/s speedup
BenchmarkReadSlice1000Int32s 47.93 47.99 1.00x
BenchmarkReadStruct 16.90 16.48 0.98x
BenchmarkReadInts 18.89 18.91 1.00x
BenchmarkWriteInts 19.35 20.15 1.04x
BenchmarkPutUvarint32 101.90 100.82 0.99x
BenchmarkPutUvarint64 56.11 55.45 0.99x
Fixes issue 4185.
Patch Set 1 #Patch Set 2 : diff -r b13d68941de6 https://code.google.com/p/go #Patch Set 3 : diff -r 8d919bfe75d3 https://code.google.com/p/go #Patch Set 4 : diff -r 8d919bfe75d3 https://code.google.com/p/go #Patch Set 5 : diff -r 8d919bfe75d3 https://code.google.com/p/go #
Total comments: 2
Patch Set 6 : diff -r 2da23e50774a https://code.google.com/p/go #Patch Set 7 : diff -r d9a624c22a62 https://code.google.com/p/go #Patch Set 8 : diff -r d9a624c22a62 https://code.google.com/p/go #Patch Set 9 : diff -r 956500178964 https://code.google.com/p/go #Patch Set 10 : diff -r 4c898bf605a5 https://code.google.com/p/go #
MessagesTotal messages: 7
|