Issue 6726052: code review 6726052: go.talks/present: add .html function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6726052: code review 6726052: go.talks/present: add .html function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by adg

Modified:
11 years, 6 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 0a31f1cf3042 https://code.google.com/p/go.talks #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -14 lines)			Patch
M	present/code.go	View	3 chunks	+3 lines, -12 lines	0 comments	Download
M	present/doc.go	View	3 chunks	+10 lines, -0 lines	0 comments	Download
A	present/html.go	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	present/parse.go	View	3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 6 months ago (2012-10-17 01:58:06 UTC) #1

http://codereview.appspot.com/6726052/diff/1/present/doc.go File present/doc.go (right): http://codereview.appspot.com/6726052/diff/1/present/doc.go#newcode167 present/doc.go:167: that cannot be created using only the slide format. ...

11 years, 6 months ago (2012-10-17 02:26:00 UTC) #2

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=2147a6840a68&repo=talks *** go.talks/present: add .html function R=r CC=golang-dev http://codereview.appspot.com/6726052

11 years, 6 months ago (2012-10-17 04:10:04 UTC) #3

adg

11 years, 6 months ago (2012-10-17 04:49:56 UTC) #4

Oops, I missed your comments. Please continue here
http://codereview.appspot.com/6727047

https://codereview.appspot.com/6726052/diff/1/present/doc.go
File present/doc.go (right):

https://codereview.appspot.com/6726052/diff/1/present/doc.go#newcode167
present/doc.go:167: that cannot be created using only the slide format.
On 2012/10/17 02:26:00, r wrote:
> explain in strong terms that it's your responsibility to make that HTML safe.

OK. But it's not that big a deal because it's not end-user provided html, but
author-provided html.

https://codereview.appspot.com/6726052/diff/1/present/html.go
File present/html.go (right):

https://codereview.appspot.com/6726052/diff/1/present/html.go#newcode25
present/html.go:25: return HTML(b), nil
On 2012/10/17 02:26:00, r wrote:
> does this compile? that nil looks wrong.

Why wouldn't it? the function returns (Elem, error)

https://codereview.appspot.com/6726052/diff/1/present/parse.go
File present/parse.go (right):

https://codereview.appspot.com/6726052/diff/1/present/parse.go#newcode40
present/parse.go:40: if function != nil {
On 2012/10/17 02:26:00, r wrote:
> explain this. it's not obvious what's happening.

Done.

Expand All Messages | Collapse All Messages