Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1348)

Issue 6700043: code review 6700043: present: fix race condition (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dvyukov
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

present: fix race condition If one hits "Run" several times, then an old process removes the current process from c.proc. As a result the new process can't be killed, and we end up with 2 processes running at the same time.

Patch Set 1 #

Patch Set 2 : diff -r 51f60b2c6742 https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Patch Set 3 : diff -r 51f60b2c6742 https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Patch Set 4 : diff -r 51f60b2c6742 https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Patch Set 5 : diff -r 764d8c2ea85e https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Patch Set 6 : diff -r 764d8c2ea85e https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Patch Set 7 : diff -r 764d8c2ea85e https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Patch Set 8 : diff -r 764d8c2ea85e https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Patch Set 9 : diff -r 764d8c2ea85e https://dvyukov%40google.com@code.google.com/p/go.talks/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M present/socket.go View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go.talks/
11 years, 6 months ago (2012-10-15 16:07:18 UTC) #1
adg
LGTM Thanks!
11 years, 6 months ago (2012-10-16 05:01:37 UTC) #2
adg
Please hg sync and hg upload.
11 years, 6 months ago (2012-10-16 05:57:07 UTC) #3
dvyukov
11 years, 6 months ago (2012-10-16 06:35:45 UTC) #4
*** Submitted as
http://code.google.com/p/go/source/detail?r=a36292b60407&repo=talks ***

present: fix race condition
If one hits "Run" several times, then an old process removes the current process
from c.proc.
As a result the new process can't be killed, and we end up with 2 processes
running at the same time.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/6700043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b