Issue 6674052: code review 6674052: go.talks/present: don't listen on /socket when -play=false

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6674052: code review 6674052: go.talks/present: don't listen on /socket when -play=false (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by adg

Modified:
11 years, 7 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go.talks/present: don't listen on /socket when -play=false

Patch Set 1 #

Patch Set 2 : diff -r 2967b28a3e86 https://code.google.com/p/go.talks #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -4 lines)			Patch
M	present/appengine.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	present/main.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	present/socket.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 7 months ago (2012-10-15 06:38:17 UTC) #1

adg

11 years, 7 months ago (2012-10-15 06:39:48 UTC) #3

*** Submitted as
http://code.google.com/p/go/source/detail?r=51f60b2c6742&repo=talks ***

go.talks/present: don't listen on /socket when -play=false

R=r
CC=golang-dev
http://codereview.appspot.com/6674052

Expand All Messages | Collapse All Messages