code review 6674051: go.talks/present: give presenter fields a more free format

go.talks/present: give presenter fields a more free format

[adg, 2012-10-15 06:08:47]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[gobot, 2012-10-15 06:09:08]

R=r (assigned by adg)

[r, 2012-10-15 06:32:03]

https://codereview.appspot.com/6674051/diff/1/present/doc.go
File present/doc.go (right):

https://codereview.appspot.com/6674051/diff/1/present/doc.go#newcode36
present/doc.go:36: Only the first text lines will be displayed on the
presentation front page.
what does 'first' mean

https://codereview.appspot.com/6674051/diff/1/present/parse.go
File present/parse.go (right):

https://codereview.appspot.com/6674051/diff/1/present/parse.go#newcode86
present/parse.go:86: func (p *Presenter) TextElem() (els []Elem) {
s/els/elems/g

https://codereview.appspot.com/6674051/diff/1/present/parse.go#newcode306
present/parse.go:306: // Seek to the next non empty line and go back.
s/non empty/non-empty/

s/ and go back//  (you don't go back)

simpler suggestion:

Skip blank lines.

https://codereview.appspot.com/6674051/diff/1/present/parse.go#newcode341
present/parse.go:341: case strings.HasPrefix(text, "@"):
what about
jerk@bogus.com
would be nice to make a mailto: link

[adg, 2012-10-15 06:49:09]

PTAL

https://codereview.appspot.com/6674051/diff/1/present/doc.go
File present/doc.go (right):

https://codereview.appspot.com/6674051/diff/1/present/doc.go#newcode36
present/doc.go:36: Only the first text lines will be displayed on the
presentation front page.
On 2012/10/15 06:32:04, r wrote:
> what does 'first' mean

perhaps 'leading'? It means that only the text lines before a link or twitter
name are shown on the first page.

https://codereview.appspot.com/6674051/diff/1/present/parse.go
File present/parse.go (right):

https://codereview.appspot.com/6674051/diff/1/present/parse.go#newcode86
present/parse.go:86: func (p *Presenter) TextElem() (els []Elem) {
On 2012/10/15 06:32:04, r wrote:
> s/els/elems/g

Done.

https://codereview.appspot.com/6674051/diff/1/present/parse.go#newcode306
present/parse.go:306: // Seek to the next non empty line and go back.
On 2012/10/15 06:32:04, r wrote:
> s/non empty/non-empty/
> 
> s/ and go back//  (you don't go back)
> 
> simpler suggestion:
> 
> Skip blank lines.

Done.

https://codereview.appspot.com/6674051/diff/1/present/parse.go#newcode341
present/parse.go:341: case strings.HasPrefix(text, "@"):
On 2012/10/15 06:32:04, r wrote:
> what about
> mailto:jerk@bogus.com
> would be nice to make a mailto: link

mailto:jerk@bogus.com should convert to
<a href="mailto:jerk@bogus.com">jerk@bogus.com</a>

[adg, 2012-10-15 06:53:13]

Hello r@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com),

Please take another look.

[r, 2012-10-15 06:53:40]

i don't see where the mailto: stuff happens.

https://codereview.appspot.com/6674051/diff/7001/present/doc.go
File present/doc.go (right):

https://codereview.appspot.com/6674051/diff/7001/present/doc.go#newcode36
present/doc.go:36: Only the leading text lines will be displayed on the
presentation front page.
Only lines without at signs or slashes...

[adg, 2012-10-15 06:55:23]

On 15 October 2012 17:53,  <r@golang.org> wrote:
> i don't see where the mailto: stuff happens.

Take another look. I misspoke in my comment but quickly made the code
reflect my statement. Check link.go.

Andrew

[adg, 2012-10-15 06:55:30]

Hello r@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com),

Please take another look.

[r, 2012-10-15 06:58:36]

I think we're at cross purposes. I'm trying to say that in the author
section moron@idiot.com should automatically become a link.

-rob

[adg, 2012-10-16 00:43:33]

Hello r@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com),

Please take another look.

[r, 2012-10-16 00:47:38]

LGTM

http://codereview.appspot.com/6674051/diff/18001/present/doc.go
File present/doc.go (right):

http://codereview.appspot.com/6674051/diff/18001/present/doc.go#newcode37
present/doc.go:37: Only the lines without links or twitter names will be
displayed on the
or mail addresses. maybe

Only the plain text lines (no links, etc.) will be displayed...

[adg, 2012-10-16 01:27:22]

*** Submitted as
http://code.google.com/p/go/source/detail?r=70dd3a95ee02&repo=talks ***

go.talks/present: give presenter fields a more free format

R=r
CC=gobot, golang-dev
http://codereview.appspot.com/6674051