Issue 66700043: code review 66700043: ogle/probe: rewrite validRead and validWrite to use the...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66700043: code review 66700043: ogle/probe: rewrite validRead and validWrite to use the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by r

Modified:
10 years, 2 months ago

Reviewers:
nigeltao

CC:
nigeltao

Visibility:
Public.

Description

ogle/probe: rewrite validRead and validWrite to use the new SetPanicOnFault function

Patch Set 2 : diff -r ac1c51d47094 https://code.google.com/p/ogle #

Total comments: 4

Patch Set 3 : diff -r ac1c51d47094 https://code.google.com/p/ogle #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -142 lines)			Patch
M	probe/addr_test.go	View	1	6 chunks	+7 lines, -54 lines	0 comments	Download
M	probe/net_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	probe/probe.go	View	1 2	2 chunks	+33 lines, -39 lines	0 comments	Download
M	probe/probe_darwin_amd64.s	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	probe/probe_linux_amd64.s	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle

10 years, 2 months ago (2014-02-21 00:00:59 UTC) #1

nigeltao

LGTM. https://codereview.appspot.com/66700043/diff/20001/probe/probe.go File probe/probe.go (right): https://codereview.appspot.com/66700043/diff/20001/probe/probe.go#newcode14 probe/probe.go:14: // catchFault is used by The suspense is ...

10 years, 2 months ago (2014-02-21 00:23:06 UTC) #3

10 years, 2 months ago (2014-02-21 00:25:31 UTC) #4

*** Submitted as https://code.google.com/p/ogle/source/detail?r=a41fee5ddf57 ***

ogle/probe: rewrite validRead and validWrite to use the new SetPanicOnFault
function

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/66700043

Expand All Messages | Collapse All Messages