Issue 66670043: code review 66670043: go.tools/dashboard/builder: fix imported by not used error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66670043: code review 66670043: go.tools/dashboard/builder: fix imported by not used error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dave

Modified:
11 years, 3 months ago

Reviewers:
bgarcia

CC:
golang-codereviews, bgarcia

Visibility:
Public.

Description

go.tools/dashboard/builder: fix imported by not used error Update issue 7372 This slipped into the build in revision 4b4229fc616b. Thanks to @pierredurand87 for noticing the break.

Patch Set 1 #

Patch Set 2 : diff -r 85161f0e5961 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 85161f0e5961 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 67afad85d9a4 https://code.google.com/p/go.tools #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	dashboard/builder/env.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 3 months ago (2014-02-20 22:05:05 UTC) #1

dave_cheney.net

11 years, 3 months ago (2014-02-22 02:25:14 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=08c7e94f38c8&repo=tools ***

go.tools/dashboard/builder: fix imported by not used error

Update issue 7372

This slipped into the build in revision 4b4229fc616b.

Thanks to @pierredurand87 for noticing the break.

LGTM=bgarcia
R=golang-codereviews, bgarcia
CC=golang-codereviews
https://codereview.appspot.com/66670043

Expand All Messages | Collapse All Messages