Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(360)

Issue 6653047: code review 6653047: spec: more clarification about deferred functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by r
Modified:
12 years, 4 months ago
Reviewers:
gri
CC:
golang-dev, iant
Visibility:
Public.

Description

spec: more clarification about deferred functions Proposed new text to make matters clearer. The existing text was unclear about the state of result parameters when panicking.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r a9280640383f https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r a9280640383f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 79795b342a76 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 3e39b4ebe5b1 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M doc/go_spec.html View 1 2 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 5 months ago (2012-10-12 04:00:11 UTC) #1
iant
https://codereview.appspot.com/6653047/diff/1/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6653047/diff/1/doc/go_spec.html#newcode4760 doc/go_spec.html:4760: <a href="#Run_time_panics">run-time panic</a> occurs, as described The reference to ...
12 years, 5 months ago (2012-10-12 05:21:08 UTC) #2
r
Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 5 months ago (2012-10-12 05:24:49 UTC) #3
iant
LGTM https://codereview.appspot.com/6653047/diff/3002/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6653047/diff/3002/doc/go_spec.html#newcode4738 doc/go_spec.html:4738: (See aslo the section on <a href="#Handling_panics">handling panics</a>.) ...
12 years, 5 months ago (2012-10-12 05:54:22 UTC) #4
r
Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 4 months ago (2012-10-14 23:39:24 UTC) #5
iant
LGTM
12 years, 4 months ago (2012-10-15 16:43:43 UTC) #6
r
*** Submitted as http://code.google.com/p/go/source/detail?r=66d7f5cb2d22 *** spec: more clarification about deferred functions Proposed new text to ...
12 years, 4 months ago (2012-10-16 00:27:31 UTC) #7
gri
12 years, 4 months ago (2012-10-16 04:23:36 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b