Issue 6639064: code review 6639064: doc/faq: discuss virtual memory use by go processes (Closed)
|
Created:
12 years, 5 months ago by adg Modified:
12 years, 5 months ago Reviewers:
CC:
golang-dev, r, dave_cheney.net, dsymonds Visibility:
Public. |
Descriptiondoc/faq: discuss virtual memory use by go processes
Fixes issue 3948.
Patch Set 1 #
Total comments: 18
Patch Set 2 : diff -r c508477a0dfd https://code.google.com/p/go #Patch Set 3 : diff -r 767901053800 https://code.google.com/p/go #
Total comments: 2
Patch Set 4 : diff -r 767901053800 https://code.google.com/p/go #MessagesTotal messages: 10
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
Sign in to reply to this message.
http://codereview.appspot.com/6639064/diff/1/doc/go_faq.html File doc/go_faq.html (right): http://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1107 doc/go_faq.html:1107: use as an arena for future allocations. Note that this virtual memory is s/Note that this/This/ http://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1116 doc/go_faq.html:1116: <code>RSIZE</code> (Mac OS X) columns. find out how on windows
Sign in to reply to this message.
https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1106 doc/go_faq.html:1106: The Go memory allocator allocates a large slab of virtual memory on startup to s/allocates/uses/ s/on startup to// https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1107 doc/go_faq.html:1107: use as an arena for future allocations. Note that this virtual memory is s/use //
Sign in to reply to this message.
Thank you for taking a stab at this. Fixes issue 3948. https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1106 doc/go_faq.html:1106: The Go memory allocator allocates a large slab of virtual memory on startup to s/allocates/reserves/ https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1107 doc/go_faq.html:1107: use as an arena for future allocations. Note that this virtual memory is <em>virtual</em> https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1108 doc/go_faq.html:1108: local to the specific Go process; the allocation does not deprive other s/allocation/reservation/ https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1109 doc/go_faq.html:1109: processes of memory. For more detail read ... of memory unless your program's heap usage grows substantially.
Sign in to reply to this message.
PTAL https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1106 doc/go_faq.html:1106: The Go memory allocator allocates a large slab of virtual memory on startup to On 2012/10/11 00:59:42, dsymonds wrote: > s/allocates/uses/ > s/on startup to// Done. https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1106 doc/go_faq.html:1106: The Go memory allocator allocates a large slab of virtual memory on startup to On 2012/10/11 01:00:34, dfc wrote: > s/allocates/reserves/ Done. https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1107 doc/go_faq.html:1107: use as an arena for future allocations. Note that this virtual memory is On 2012/10/11 01:00:34, dfc wrote: > <em>virtual</em> nah https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1107 doc/go_faq.html:1107: use as an arena for future allocations. Note that this virtual memory is On 2012/10/11 00:59:42, dsymonds wrote: > s/use // Done. https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1107 doc/go_faq.html:1107: use as an arena for future allocations. Note that this virtual memory is On 2012/10/11 00:59:26, r wrote: > s/Note that this/This/ Done. https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1108 doc/go_faq.html:1108: local to the specific Go process; the allocation does not deprive other On 2012/10/11 01:00:34, dfc wrote: > s/allocation/reservation/ Done. https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1109 doc/go_faq.html:1109: processes of memory. For more detail read On 2012/10/11 01:00:34, dfc wrote: > ... of memory unless your program's heap usage grows substantially. seems unnecessary https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1116 doc/go_faq.html:1116: <code>RSIZE</code> (Mac OS X) columns. On 2012/10/11 00:59:26, r wrote: > find out how on windows Added a TODO, for now. I think the task manager just displays the resident memory.
Sign in to reply to this message.
https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1106 doc/go_faq.html:1106: The Go memory allocator allocates a large slab of virtual memory on startup to s/slab/region/
Sign in to reply to this message.
PTAL https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/6639064/diff/1/doc/go_faq.html#newcode1106 doc/go_faq.html:1106: The Go memory allocator allocates a large slab of virtual memory on startup to On 2012/10/11 02:02:36, r wrote: > s/slab/region/ Done.
Sign in to reply to this message.
LGTM
Sign in to reply to this message.
LGTM after deletion https://codereview.appspot.com/6639064/diff/10001/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/6639064/diff/10001/doc/go_faq.html#newcode1107 doc/go_faq.html:1107: for future allocations. This virtual memory is local to the specific Go s/future // https://codereview.appspot.com/6639064/diff/10001/doc/go_faq.html#newcode1110 doc/go_faq.html:1110: <a href="https://groups.google.com/forum/#!msg/golang-dev/EpUlHQXWykg/LN2o9fV6R3wJ">this discussion on golang-dev</a>. delete this sentence and the reference. it's unnecessary. cross-connecting like this will drive traffic to the list, generating more misinformation. reference only curated, fixed content.
Sign in to reply to this message.
*** Submitted as http://code.google.com/p/go/source/detail?r=8f3e3876b690 *** doc/faq: discuss virtual memory use by go processes Fixes issue 3948. R=golang-dev, r, dave, dsymonds CC=golang-dev http://codereview.appspot.com/6639064
Sign in to reply to this message.
|
