code review 6637061: cmd/dist: fix superfluous and confusing "binaries ... t...

cmd/dist: fix superfluous and confusing "binaries ... to be copied or moved" message
Also, to aid debugging cmd/dist, make make.bat support --dist-tool flag.

Fixes issue 3100.

[minux1, 2012-10-10 15:56:08]

Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[brainman, 2012-10-11 01:21:48]

Thank you for doing that.

Alex

http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c
File src/cmd/dist/windows.c (right):

http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c#newcode936
src/cmd/dist/windows.c:936: r = 0;
Feel free to ignore, but I would not use this variable. Just put returns
everywhere. Also, I think, less gotos is better.

http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c#newcode943
src/cmd/dist/windows.c:943: fd1 = CreateFile(f1, 0, 0, NULL, OPEN_EXISTING,
FILE_FLAG_BACKUP_SEMANTICS, 0);
s/CreateFile/CreateFileW/

You, of all people, should be using utf16 versionof this function :-)

http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c#newcode943
src/cmd/dist/windows.c:943: fd1 = CreateFile(f1, 0, 0, NULL, OPEN_EXISTING,
FILE_FLAG_BACKUP_SEMANTICS, 0);
Once you use CreateFileW, you must convert f1 into its utf16 version. See torune
for that.

http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c#newcode946
src/cmd/dist/windows.c:946: fd2 = CreateFile(f2, 0, 0, NULL, OPEN_EXISTING,
FILE_FLAG_BACKUP_SEMANTICS, 0);
s/CreateFile/CreateFileW/

http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c#newcode946
src/cmd/dist/windows.c:946: fd2 = CreateFile(f2, 0, 0, NULL, OPEN_EXISTING,
FILE_FLAG_BACKUP_SEMANTICS, 0);
Same. Use torune for f2

[minux1, 2012-10-11 19:06:54]

PTAL.
I missed defer very much...

On 2012/10/11 01:21:48, brainman wrote:
> http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c#newcode936
> src/cmd/dist/windows.c:936: r = 0;
> Feel free to ignore, but I would not use this variable. Just put returns
> everywhere. Also, I think, less gotos is better.
Sure, removed all gotos, and used a new way to organize, should be clearer.
 
> http://codereview.appspot.com/6637061/diff/9/src/cmd/dist/windows.c#newcode943
> src/cmd/dist/windows.c:943: fd1 = CreateFile(f1, 0, 0, NULL, OPEN_EXISTING,
> FILE_FLAG_BACKUP_SEMANTICS, 0);
> s/CreateFile/CreateFileW/
All CreateFile changed to CreateFileW, with torune() added as necessary.

[brainman, 2012-10-12 01:55:36]

LGTM

Thank you very much.

Alex

[minux1, 2012-10-12 05:35:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=43d23086b2ad ***

cmd/dist: fix superfluous and confusing "binaries ... to be copied or moved"
message
Also, to aid debugging cmd/dist, make make.bat support --dist-tool flag.

Fixes issue 3100.

R=alex.brainman
CC=golang-dev
http://codereview.appspot.com/6637061