Issue 6637052: code review 6637052: crypto/tls: fix NPN extension parsing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6637052: code review 6637052: crypto/tls: fix NPN extension parsing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by agl1

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

crypto/tls: fix NPN extension parsing. I typoed the code and tried to parse all the way to the end of the message. Therefore it fails when NPN is not the last extension in the ServerHello. Fixes issue 4088.

Patch Set 1 #

Patch Set 2 : diff -r 8230013d1c40 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8230013d1c40 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8230013d1c40 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 6976c7f91270 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	src/pkg/crypto/tls/handshake_messages.go	View	1 2 3	3 chunks	+5 lines, -2 lines	0 comments	Download
	M	src/pkg/crypto/tls/handshake_messages_test.go	View	1 2 3	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2012-10-09 15:23:05 UTC) #1

agl1

Struggled to figure out a good way to test this until I noticed that I ...

11 years, 7 months ago (2012-10-09 16:47:06 UTC) #3

agl1

11 years, 7 months ago (2012-10-09 17:26:05 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=5d67dcbdd195 ***

crypto/tls: fix NPN extension parsing.

I typoed the code and tried to parse all the way to the end of the
message. Therefore it fails when NPN is not the last extension in the
ServerHello.

Fixes issue 4088.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6637052

Expand All Messages | Collapse All Messages