Issue 66260043: code review 66260043: ogle/gosym: new package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66260043: code review 66260043: ogle/gosym: new package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by nigeltao

Modified:
10 years, 2 months ago

Reviewers:
r

CC:
r

Visibility:
Public.

Description

ogle/gosym: new package. This is a fork of $GOROOT/src/pkg/debug/gosym. I intend to add experimental API, but am not yet ready to make the standard library's backwards compatibility commitment. This CL is a straight copy from Go tip with no changes. Future CLs will add code. $ cd $GOROOT/src/pkg/debug/gosym $ hg identify da7a98d40bd5+ tip

Patch Set 1 #

Patch Set 2 : diff -r 11112a8e1795 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 11112a8e1795 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 11112a8e1795 https://code.google.com/p/ogle #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1470 lines, -0 lines)			Patch
A	gosym/pclinetest.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	gosym/pclinetest.asm	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
A	gosym/pclntab.go	View	1	1 chunk	+426 lines, -0 lines	0 comments	Download
A	gosym/pclntab_test.go	View	1	1 chunk	+274 lines, -0 lines	0 comments	Download
A	gosym/symtab.go	View	1	1 chunk	+703 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

10 years, 2 months ago (2014-02-20 01:03:59 UTC) #1

nigeltao

10 years, 2 months ago (2014-02-20 01:39:22 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=ac1c51d47094 ***

ogle/gosym: new package.

This is a fork of $GOROOT/src/pkg/debug/gosym. I intend to add
experimental API, but am not yet ready to make the standard library's
backwards compatibility commitment.

This CL is a straight copy from Go tip with no changes. Future CLs will
add code.
$ cd $GOROOT/src/pkg/debug/gosym
$ hg identify
da7a98d40bd5+ tip

LGTM=r
R=r
https://codereview.appspot.com/66260043

Expand All Messages | Collapse All Messages