code review 6625073: go.talks/present: support fontifying markers

go.talks/present: support fontifying markers

[r, 2012-10-10 06:06:56]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[adg, 2012-10-10 06:22:56]

Nice!

https://codereview.appspot.com/6625073/diff/1/present/doc.go
File present/doc.go (right):

https://codereview.appspot.com/6625073/diff/1/present/doc.go#newcode81
present/doc.go:81: _Why_use_scoped__ptr_? Use plain *ptr instead.
Use ***ptr*!

https://codereview.appspot.com/6625073/diff/1/present/style.go
File present/style.go (right):

https://codereview.appspot.com/6625073/diff/1/present/style.go#newcode19
present/style.go:19: Fonts are demarcated by an initial and final char
bracketing a
Add tests!

https://codereview.appspot.com/6625073/diff/1/present/style.go#newcode31
present/style.go:31: const codifyChar = "`"
delete

https://codereview.appspot.com/6625073/diff/1/present/style.go#newcode33
present/style.go:33: var codifyRE = regexp.MustCompile(fmt.Sprintf("%s[^%s]+%s",
codifyChar, codifyChar, codifyChar))
delete

https://codereview.appspot.com/6625073/diff/1/present/style.go#newcode40
present/style.go:40: return template.HTML(codifyRE.ReplaceAllStringFunc(s,
repl))
delete the codifyRE invocation

https://codereview.appspot.com/6625073/diff/1/present/style.go#newcode55
present/style.go:55: char := word[0] // ASCII is OK.
not just OK; ASCII is GREAT

[r, 2012-10-10 08:41:28]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2012-10-11 06:49:38]

LGTM

https://codereview.appspot.com/6625073/diff/7/present/doc.go
File present/doc.go (right):

https://codereview.appspot.com/6625073/diff/7/present/doc.go#newcode81
present/doc.go:81: _Why_use_scoped__ptr_? Use plain *ptr instead.
***ptr*

https://codereview.appspot.com/6625073/diff/7/present/style_test.go
File present/style_test.go (right):

https://codereview.appspot.com/6625073/diff/7/present/style_test.go#newcode47
present/style_test.go:47: {"_Why_use_scoped__ptr_? Use plain *ptr instead.",
"<i>Why use scoped_ptr</i>? Use plain *ptr instead."},
***ptr*
<b>*ptr</b>

[r, 2012-10-11 07:41:38]

*** Submitted as
http://code.google.com/p/go/source/detail?r=f7ae38c5519e&repo=talks ***

go.talks/present: support fontifying markers

R=adg
CC=golang-dev
http://codereview.appspot.com/6625073

[r, 2012-10-15 00:10:04]

*** Abandoned ***

[r, 2012-10-15 00:37:36]

On Mon, Oct 15, 2012 at 11:10 AM,  <r@golang.org> wrote:
> *** Abandoned ***

not abandoned, just checked in from another machine.