Issue 6624051: code review 6624051: go/printer: idempotent comment formatting (Closed)
Descriptiongo/printer: idempotent comment formatting
Also:
- Refactored testing framework to permit easier
idempotency testing.
- Applied gofmt -w src misc
This CL depends on CL 6639044 being applied first.
Formatting is not idempotent for all files: In those
files the comment position has changed (due to missing
precise location information) and/or the comment formatting
cannot/is not aware of independent code re-formatting.
In general it is very hard to make format idempotent when
running it in one pass only. Leaving that aside for now.
Fixes issue 1835.
Patch Set 1 #Patch Set 2 : diff -r 97b5f757b30e https://code.google.com/p/go #Patch Set 3 : diff -r 97b5f757b30e https://code.google.com/p/go #Patch Set 4 : diff -r 97b5f757b30e https://code.google.com/p/go #Patch Set 5 : diff -r c1fb176f3ec7 https://code.google.com/p/go #Patch Set 6 : diff -r 6976c7f91270 https://code.google.com/p/go #Patch Set 7 : diff -r 1b587887ceb2 https://code.google.com/p/go #Patch Set 8 : diff -r 1b587887ceb2 https://code.google.com/p/go #Patch Set 9 : diff -r 1b587887ceb2 https://code.google.com/p/go #
Total comments: 1
Patch Set 10 : diff -r 7a30d6a1d918 https://code.google.com/p/go #
MessagesTotal messages: 3
|
||||||||||||||||||||||||||||||||||||||||||||||
